Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DL: delete full files for when subscribed to a datastore per config #16850

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

fchirica
Copy link
Contributor

@fchirica fchirica commented Nov 16, 2023

Purpose:

Fix issue with subscribers collecting full files for subscribed data stores

Current Behavior:

Bug report re: full files. The data store owner now only creates the latest full file, but the clients receive and store every full file. The client never deletes full files from prior generations

New Behavior:

The subscribed client deletes full files from prior generations following the setting in the config

Testing Notes:

@fchirica fchirica added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Nov 16, 2023
Copy link
Contributor

File Coverage Missing Lines
chia/data_layer/data_layer.py 90.0% lines 526
Total Missing Coverage
10 lines Unknown 90%

@fchirica fchirica marked this pull request as ready for review November 17, 2023 00:43
@fchirica fchirica requested a review from a team as a code owner November 17, 2023 00:43
@emlowe emlowe changed the base branch from main to release/2.1.2 November 27, 2023 18:14
@emlowe emlowe changed the title DL: delete full files for clients too. DL: delete full files for when subscribed to a datastore per config Nov 27, 2023
@cmmarslender cmmarslender merged commit d80b751 into release/2.1.2 Nov 27, 2023
253 of 255 checks passed
@cmmarslender cmmarslender deleted the fc.dl_client_delete_files branch November 27, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataLayer Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants