Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asyncio.create_subprocess_shell() -> asyncio.create_subprocess_exec() #16944

Merged
merged 1 commit into from
Nov 28, 2023
Merged

asyncio.create_subprocess_shell() -> asyncio.create_subprocess_exec() #16944

merged 1 commit into from
Nov 28, 2023

Conversation

altendky
Copy link
Contributor

Purpose:

avoid a ci hang in 3.11 on linux only.

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky requested a review from a team as a code owner November 28, 2023 19:28
@altendky altendky marked this pull request as draft November 28, 2023 19:28
@aqk
Copy link
Contributor

aqk commented Nov 28, 2023

I know dirname is where the binary is, but was dirname also the CWD of the previous code?

https://github.com/Chia-Network/chia-blockchain/pull/16944/files#diff-1054b958a0759914ed87f5b4bcdf6de32cecad90d3f380d79c1bad6ec4061f41R98

@altendky altendky added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Nov 28, 2023
@altendky altendky marked this pull request as ready for review November 28, 2023 20:22
@altendky altendky mentioned this pull request Nov 28, 2023
Closed
@arvidn
Copy link
Contributor

arvidn commented Nov 28, 2023

feel free to resolve my comment. I got carried away, it should have been a non-blocking comment

@cmmarslender cmmarslender merged commit fab8b21 into release/2.1.2 Nov 28, 2023
577 of 580 checks passed
@cmmarslender cmmarslender deleted the asyncio.create_subprocess_exec branch November 28, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aqk aqk aqk approved these changes

@arvidn arvidn arvidn approved these changes

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@altendky @aqk @arvidn @emlowe @cmmarslender