Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiohttp 3.9.1 to fix a WebSocket bug introduced in 3.9.0 #16968

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

paninaro
Copy link
Contributor

Purpose:

aiohttp 3.9.0 introduced new compression support that was enabled by default. This compression support had a bug that could cause WebSocket frames to get mixed up, causing problems for the GUI. The observed behavior was that multiple responses from the Chia daemon could appear in a single message, breaking message parsing in the GUI.

This bug has been fixed in aiohttp 3.9.1.

Commit that fixes the issue in aiohttp:
aio-libs/aiohttp#7859

Bug reported against aiohttp:
aio-libs/aiohttp#7859

Testing Notes:

Manually tested going back and forth between 3.8.6, 3.9.0, and 3.9.1 and testing against the GUI.

@paninaro paninaro added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Nov 29, 2023
@paninaro paninaro requested a review from a team as a code owner November 29, 2023 23:11
@paninaro paninaro changed the base branch from main to release/2.1.2 November 29, 2023 23:12
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

Copy link

Pull Request Test Coverage Report for Build 7039661222

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 176 unchanged lines in 31 files lost coverage.
  • Overall coverage decreased (-0.09%) to 90.342%

Files with Coverage Reduction New Missed Lines %
chia/daemon/client.py 1 84.38%
chia/daemon/keychain_proxy.py 1 64.98%
chia/data_layer/download_data.py 1 71.04%
chia/farmer/farmer.py 1 66.56%
chia/rpc/wallet_rpc_api.py 1 88.1%
chia/wallet/util/wallet_sync_utils.py 1 77.67%
tests/core/util/test_lockfile.py 1 91.09%
tests/fee_estimation/test_fee_estimation_unit_tests.py 1 99.06%
tests/simulation/test_simulation.py 1 96.52%
tests/util/test_priority_mutex.py 1 99.66%
Totals Coverage Status
Change from base Build 7034809179: -0.09%
Covered Lines: 93630
Relevant Lines: 103600

💛 - Coveralls

@cmmarslender cmmarslender merged commit 55057df into release/2.1.2 Nov 29, 2023
253 checks passed
@cmmarslender cmmarslender deleted the paninaro.bump_aiohttp_3_9_1 branch November 29, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants