aiohttp 3.9.1 to fix a WebSocket bug introduced in 3.9.0 #16968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
aiohttp 3.9.0 introduced new compression support that was enabled by default. This compression support had a bug that could cause WebSocket frames to get mixed up, causing problems for the GUI. The observed behavior was that multiple responses from the Chia daemon could appear in a single message, breaking message parsing in the GUI.
This bug has been fixed in aiohttp 3.9.1.
Commit that fixes the issue in aiohttp:
aio-libs/aiohttp#7859
Bug reported against aiohttp:
aio-libs/aiohttp#7859
Testing Notes:
Manually tested going back and forth between 3.8.6, 3.9.0, and 3.9.1 and testing against the GUI.