Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event log #16982

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

event log #16982

wants to merge 1 commit into from

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Dec 1, 2023

Purpose:

This patch adds support for enabling a binary event log for unfinished blocks, signage points and transactions.

This log is a "structured" log, i.e. it's a stream of messages in a network-protocol-like format, streamed into a file (rotated every 100 MB).

Currently the following events are logged:

  1. new peers (this is required to record information about the peers sending the other messages)
  2. Incoming UnfinishedBlocks
  3. Outgoing UnfinishedBlocks
  4. Incoming signage point
  5. incoming transaction (for the mempool)
  6. NewPeak

The intention is that this format can be extended with additional events in the future.

This patch does not include any tools for analyzing or parsing the resulting log. Those tools will be submitted in a separate PR.

@arvidn arvidn added enhancement New feature or request Added Required label for PR that categorizes merge commit message as "Added" for changelog and removed enhancement New feature or request labels Dec 1, 2023
@arvidn arvidn force-pushed the event-log branch 2 times, most recently from 8ce7fd9 to 6ca8dac Compare December 2, 2023 11:11
@arvidn arvidn marked this pull request as ready for review December 3, 2023 10:27
@arvidn arvidn requested a review from a team as a code owner December 3, 2023 10:27
Copy link
Contributor

github-actions bot commented Dec 3, 2023

File Coverage Missing Lines
chia/full_node/full_node.py 45.5% lines 302, 865-868, 878
chia/full_node/full_node_api.py 58.3% lines 133, 258, 472, 486, 628
chia/util/structured_log.py 65.5% lines 99-102, 110, 112-113, 115-128, 130, 132-133, 135-139
Total Missing Coverage
111 lines 40 lines 63%

Copy link

Pull Request Test Coverage Report for Build 7070110228

  • 71 of 111 (63.96%) changed or added relevant lines in 5 files are covered.
  • 16 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.04%) to 90.234%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/full_node/full_node_api.py 7 12 58.33%
chia/full_node/full_node.py 5 11 45.45%
chia/util/structured_log.py 55 84 65.48%
Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 77.13%
chia/introducer/introducer.py 1 78.26%
chia/plotters/madmax.py 1 50.0%
chia/server/node_discovery.py 1 78.01%
chia/wallet/wallet_state_manager.py 1 96.26%
chia/data_layer/data_layer.py 2 81.69%
chia/full_node/full_node.py 4 84.11%
chia/wallet/wallet_node.py 5 87.72%
Totals Coverage Status
Change from base Build 7051730175: -0.04%
Covered Lines: 93611
Relevant Lines: 103687

💛 - Coveralls

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jan 3, 2024
Copy link
Contributor

github-actions bot commented Jan 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog coverage-diff merge_conflict Branch has conflicts that prevent merge to main stale-pr Flagged as stale and in need of manual review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant