Add a few missing type annotations #17043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rigidity
added
the
Fixed
Pull Request Test Coverage Report for Build 7389278716Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
AmineKhaldi
previously approved these changes
Dec 12, 2023
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
altendky
requested changes
Dec 19, 2023
Co-authored-by: Kyle Altendorf <sda@fstab.net>
altendky
reviewed
Dec 19, 2023
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Co-authored-by: Kyle Altendorf <sda@fstab.net>
It should be, don't know why it didn't catch this. Do I need to configure it to lint more strictly? |
altendky
previously approved these changes
Dec 20, 2023
altendky
approved these changes
Jan 2, 2024
arvidn
approved these changes
Jan 8, 2024
mikehw
pushed a commit
to mikehw/chia-blockchain
that referenced
this pull request
Jan 11, 2024
* Add a few missing type annotations * Update chia/util/struct_stream.py Co-authored-by: Kyle Altendorf <sda@fstab.net> * Update chia/util/keyring_wrapper.py Co-authored-by: Kyle Altendorf <sda@fstab.net> * add `ClassVar` import --------- Co-authored-by: Kyle Altendorf <sda@fstab.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Adds type annotations that were missing in a few places, which mypy (configured more strictly for my editor, presumably) was complaining about.
Current Behavior:
New Behavior:
Testing Notes: