Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert StructStream.__bytes__() to a working state instead of intentional failure #17075

Merged
merged 2 commits into from
Dec 18, 2023
Merged

revert StructStream.__bytes__() to a working state instead of intentional failure #17075

merged 2 commits into from
Dec 18, 2023

Conversation

altendky
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Dec 17, 2023
arvidn
arvidn previously approved these changes Dec 17, 2023
View reviewed changes
@altendky altendky marked this pull request as ready for review December 18, 2023 15:46
@altendky altendky requested a review from a team as a code owner December 18, 2023 15:46
@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
tests/util/test_struct_stream.py 94.7% lines 311
Total Missing Coverage
21 lines Unknown 95%

@cmmarslender cmmarslender merged commit a673032 into release/2.1.3 Dec 18, 2023
583 of 584 checks passed
@cmmarslender cmmarslender deleted the minimal_revert_fix branch December 18, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@altendky @arvidn @emlowe @cmmarslender