Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initiate phasing out of the coin_solutions name in JSON structs #17089

Merged
merged 1 commit into from Dec 19, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Dec 19, 2023

in favor of coin_spends.

Purpose:

The end goal is to remove the special case JSON logic in SpendBundle.

Current Behavior:

The JSON field is just called coin_solutions.

New Behavior:

There are two fields in the JSON struct, both coin_solutions and coin_spends.

@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Dec 19, 2023
Copy link

Pull Request Test Coverage Report for Build 7262177764

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 104 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.1%) to 90.444%

Files with Coverage Reduction New Missed Lines %
tests/core/util/test_lockfile.py 1 91.09%
chia/full_node/full_node.py 2 84.32%
chia/rpc/rpc_server.py 2 87.71%
chia/timelord/timelord_api.py 2 87.85%
chia/server/node_discovery.py 4 77.84%
chia/wallet/wallet_node.py 6 87.65%
chia/full_node/full_node_api.py 8 77.16%
chia/server/server.py 8 79.66%
chia/timelord/timelord_state.py 20 69.47%
chia/timelord/timelord.py 51 73.67%
Totals Coverage Status
Change from base Build 7254734138: -0.1%
Covered Lines: 93748
Relevant Lines: 103607

💛 - Coveralls

@arvidn arvidn marked this pull request as ready for review December 19, 2023 14:24
@arvidn arvidn requested a review from a team as a code owner December 19, 2023 14:24
@arvidn arvidn requested a review from wjblanke December 19, 2023 15:20
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Dec 19, 2023
@cmmarslender cmmarslender merged commit 18c28d6 into main Dec 19, 2023
267 checks passed
@cmmarslender cmmarslender deleted the phase-out-coin_solution branch December 19, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants