Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slight simplification to get_min_fee_rate() #17092

Merged
merged 1 commit into from Dec 19, 2023
Merged

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Dec 19, 2023

Purpose:

instead of throwing an exception from get_min_fee_rate(), return None.

Current Behavior:

get_min_fee_rate() may throw an exception if the mempool limit is set small.

New Behavior:

get_min_fee_rate() does not throw an exception because the mempool limit is set small.

@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Dec 19, 2023
@arvidn arvidn marked this pull request as ready for review December 19, 2023 16:51
@arvidn arvidn requested a review from a team as a code owner December 19, 2023 16:51
@arvidn arvidn requested a review from emlowe December 19, 2023 17:54
Copy link
Contributor

File Coverage Missing Lines
chia/full_node/mempool_manager.py 88.9% lines 471
Total Missing Coverage
22 lines Unknown 95%

@cmmarslender cmmarslender merged commit 2022d6e into main Dec 19, 2023
265 of 266 checks passed
@cmmarslender cmmarslender deleted the simplify-mempool branch December 19, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants