use rust types for VDFInfo, VDFProof and ClassgroupElement #17102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
the
Changed
Pull Request Test Coverage Report for Build 7386784801
💛 - Coveralls |
arvidn
force-pushed
the
rust-vdf-types
branch
from
bd5170e
to
e8d2253
Compare
arvidn
force-pushed
the
rust-vdf-types
branch
from
e8d2253
to
294ad22
Compare
arvidn
force-pushed
the
rust-vdf-types
branch
from
294ad22
to
86382ce
Compare
altendky
requested changes
Dec 22, 2023
arvidn
force-pushed
the
rust-vdf-types
branch
from
86382ce
to
52ce339
Compare
arvidn
force-pushed
the
rust-vdf-types
branch
from
52ce339
to
e7aecf1
Compare
arvidn
force-pushed
the
rust-vdf-types
branch
from
e7aecf1
to
e6cf58e
Compare
…se types aren't dataclasses, the dataclass.replace() is changed to method replace()
arvidn
force-pushed
the
rust-vdf-types
branch
from
e6cf58e
to
ef6a3e3
Compare
altendky
approved these changes
Jan 3, 2024
|
mikehw
pushed a commit
to mikehw/chia-blockchain
that referenced
this pull request
Jan 11, 2024
…ork#17102) * use rust types for VDFInfo, VDFProof and ClassgroupElement. Since these types aren't dataclasses, the dataclass.replace() is changed to method replace() * add test for recursive_replace() * add comment in recursive_replace() hack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
This is a step towards making
FullBlocka rust type, to move enough of the block validation into rust to be able to use threads instead of processes.The rust counterparts are defined here:
https://github.com/Chia-Network/chia_rs/blob/main/chia-protocol/src/vdf.rs
https://github.com/Chia-Network/chia_rs/blob/main/chia-protocol/src/classgroup.rs
Since these types aren't dataclasses, the
dataclass.replace()is changed to methodreplace().Current Behavior:
VDFInfo,VDFProofandClasgroupElementare python types.New Behavior:
VDFInfo,VDFProofandClasgroupElementare native (rust) types.