Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe to DIDs that come into wallet #17299

Merged
merged 1 commit into from Jan 12, 2024

Conversation

Quexington
Copy link
Contributor

This addresses #17242.

There's sort of two fixes in this PR. The first subscribes to any DIDs that we sync so that when they are spent we still get their update. This is normally covered by the transactions we submit but in edge cases where transactions are not actually pushed to the wallet, we can forget to mark previous DIDs as spent.

The second fix is to make the DIDWallet.get_coin() method more robust to make sure that if we somehow get into a state where multiple DIDs are unspent, we take the unspent one with the highest confirmed height to drastically increase our chances of selecting the proper one. Should be an unnecessary change but if future bugs arise, this will mute the symptoms a bit.

@Quexington Quexington marked this pull request as ready for review January 11, 2024 16:07
@Quexington Quexington requested a review from a team as a code owner January 11, 2024 16:07
@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jan 11, 2024
Copy link

Pull Request Test Coverage Report for Build 7491404410

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 90.587%

Totals Coverage Status
Change from base Build 7490775207: 0.009%
Covered Lines: 94573
Relevant Lines: 104370

💛 - Coveralls

@cmmarslender cmmarslender merged commit b62d64d into main Jan 12, 2024
265 of 266 checks passed
@cmmarslender cmmarslender deleted the quex.debug_did_pending_coins branch January 12, 2024 15:40
@emlowe emlowe linked an issue Jan 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] DID wallet stores multiple unspent coins
4 participants