Subscribe to DIDs that come into wallet #17299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #17242.
There's sort of two fixes in this PR. The first subscribes to any DIDs that we sync so that when they are spent we still get their update. This is normally covered by the transactions we submit but in edge cases where transactions are not actually pushed to the wallet, we can forget to mark previous DIDs as spent.
The second fix is to make the
DIDWallet.get_coin()
method more robust to make sure that if we somehow get into a state where multiple DIDs are unspent, we take the unspent one with the highest confirmed height to drastically increase our chances of selecting the proper one. Should be an unnecessary change but if future bugs arise, this will mute the symptoms a bit.