You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to split a batch updates into multiple commands, by setting publish_on_chain=False inside the batch_update. If using the option, a new batch update will be continued on top of the previous one, which is saved only locally. It's possible to discard the unpublished batch by doing clear_pending_roots, or to publish it by doing publish_pending_root. Internally, this implements the new root status PENDING_BATCH, which works similarly to the previous PENDING root, except it allows batch_update to build on top of it and it's never published on chain - when it gets published, it'll change to the PENDING status.
I misunderstood and thought the pending batch -> committed status was a permanent thing rather than an intermediate change that would get reverted. My above review has several comments that I think end up related to this so I will go back through and review them now.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
AddedRequired label for PR that categorizes merge commit message as "Added" for changelogDataLayerready_to_mergeSubmitter and reviewers think this is ready
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to split a batch updates into multiple commands, by setting
publish_on_chain=False
inside thebatch_update
. If using the option, a new batch update will be continued on top of the previous one, which is saved only locally. It's possible to discard the unpublished batch by doingclear_pending_roots
, or to publish it by doingpublish_pending_root
. Internally, this implements the new root statusPENDING_BATCH
, which works similarly to the previousPENDING
root, except it allowsbatch_update
to build on top of it and it's never published on chain - when it gets published, it'll change to thePENDING
status.