New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
undo some unnecessary int type casts #17521
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
changed the title
undo some redundant int type casts
undo some unnecessary int type casts
Feb 8, 2024
arvidn
added
the
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
label
Feb 8, 2024
altendky
previously approved these changes
Feb 8, 2024
@altendky you're right that these type annotations aren't necessary. I didn't intentionally add them, I just restored this code to the state before I made any changes. I'll remove them though |
altendky
approved these changes
Feb 8, 2024
I think the missing coverage is reasonable. This is undoing recent changes (that also landed without test coverage) |
emlowe
approved these changes
Feb 8, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
ready_to_merge
Submitter and reviewers think this is ready
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
In recent changes to transition python classes to rust types, rust's python bindings exposed all integers as plain python
int
, requiring explicit casts in the python code.Now that rust's python bindings expose integer types as the correct fixed-width integer type, these type casts are unnecessary.
Current Behavior:
We have unnecessary type casts.
New Behavior:
Some unnecessary type casts have been removed.