Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup clean_node_table by leveraging relaxed foreign_keys #17769

Merged
merged 2 commits into from Mar 27, 2024
Merged

Speedup clean_node_table by leveraging relaxed foreign_keys #17769

merged 2 commits into from Mar 27, 2024

Conversation

AmineKhaldi
Copy link
Contributor

No description provided.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Mar 22, 2024
@AmineKhaldi AmineKhaldi self-assigned this Mar 22, 2024
@AmineKhaldi AmineKhaldi force-pushed the speedup_clean_node_table branch 2 times, most recently from fd22e92 to 7c60341 Compare March 25, 2024 18:10
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 8424894380

Details

  • 152 of 154 (98.7%) changed or added relevant lines in 6 files are covered.
  • 23 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.003%) to 90.84%
Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/data_layer/data_store.py 21 23 91.3%
Files with Coverage Reduction New Missed Lines %
chia/rpc/rpc_server.py 1 88.67%
chia/wallet/util/wallet_sync_utils.py 1 86.6%
chia/timelord/timelord_launcher.py 1 69.92%
chia/full_node/weight_proof.py 2 90.88%
chia/farmer/farmer_api.py 2 94.4%
chia/plotters/madmax.py 3 49.4%
chia/introducer/introducer_api.py 5 78.26%
chia/wallet/wallet_node.py 8 87.98%
Totals Coverage Status
Change from base Build 8423807279: 0.003%
Covered Lines: 97545
Relevant Lines: 107357
💛 - Coveralls

fchirica
fchirica previously approved these changes Mar 27, 2024
View reviewed changes
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Mar 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Mar 27, 2024
@AmineKhaldi AmineKhaldi changed the title [RFC] Optimize clean_node_table's query and leverage relaxed foreign_keys to speed it up Speedup clean_node_table by leveraging relaxed foreign_keys Mar 27, 2024
@AmineKhaldi AmineKhaldi removed the Cleanup Code cleanup label Mar 27, 2024
@AmineKhaldi AmineKhaldi marked this pull request as ready for review March 27, 2024 16:40
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner March 27, 2024 16:40
altendky
altendky previously requested changes Mar 27, 2024
View reviewed changes
chia/data_layer/data_store.py Outdated Show resolved Hide resolved
emlowe
emlowe previously approved these changes Mar 27, 2024
View reviewed changes
@altendky altendky dismissed their stale review March 27, 2024 18:04

concern addressed

@emlowe emlowe requested review from emlowe and altendky March 27, 2024 18:12
@pmaslana pmaslana merged commit 105f071 into Chia-Network:main Mar 27, 2024
304 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

@fchirica fchirica fchirica approved these changes

@emlowe emlowe emlowe approved these changes

@altendky altendky Awaiting requested review from altendky

Assignees

@AmineKhaldi AmineKhaldi

Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AmineKhaldi @altendky @arvidn @fchirica @emlowe @pmaslana