Separate protocol versions #17791
Merged
Separate protocol versions #17791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
the
Changed
arvidn
commented
Mar 27, 2024
arvidn
force-pushed
the
separate-protocol-versions
branch
from
7ea6cb2
to
69a6126
Compare
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
merge_conflict
Rigidity
reviewed
Mar 27, 2024
arvidn
force-pushed
the
separate-protocol-versions
branch
from
69a6126
to
70866e6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
merge_conflict
This comment was marked as outdated.
This comment was marked as outdated.
Rigidity
previously approved these changes
Mar 28, 2024
arvidn
force-pushed
the
separate-protocol-versions
branch
from
70866e6
to
967b362
Compare
10 tasks
arvidn
force-pushed
the
separate-protocol-versions
branch
from
967b362
to
e373852
Compare
|
I think it's fine to not have coverage for the warning |
Rigidity
previously approved these changes
Mar 28, 2024
emlowe
requested changes
Mar 28, 2024
emlowe
approved these changes
Mar 28, 2024
|
arvidn
added
ready_to_merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
As we introduced CHIP-22, supporting 3rd party harvesters, the Harvester protocol version should only be bumped if there are changes to it. Right now, all our protocol version numbers always increase in lock-step. Disconnecting them allows for more precise warnings in case the two ends of a connection uses different versions.
Current Behavior:
The protocol version for FullNode, Wallet, Farmer and Harvester are all defined by a single constant, and always update in lock-step.
New Behavior:
The versions of the different protocols can be bumped independently, depending on which protocol is updated.