Observer Mode #17792
Merged
Observer Mode #17792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Added
altendky
previously requested changes
Mar 27, 2024
Quexington
force-pushed
the
quex.observer_mode_into_main
branch
from
9d1cb4b
to
6a05d23
Compare
|
This is in draft because it probably should not go in while there is an outstanding release branch. |
github-actions
bot
added
the
merge_conflict
github-actions
bot
removed
the
merge_conflict
github-actions
bot
added
the
merge_conflict
github-actions
bot
removed
the
merge_conflict
|
|
This is probably the reason for the coverage issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first "catchup" into main for a feature from the long_lived/vault branch: observer mode.
With these changes, it will be possible to add just a pubkey to the keyring and wallets will sync balances as usual. What this does not add is the ability to sign transactions externally with the Chia Wallet, although the hooks to do so are included so in theory external signers could begin to be developed (pending confirmation of CHIPs 27-31). The Chia Wallet as a signer will likely be the next stage of "catchup"s from the long lived branch.
Changes from the following PRs are included in this diff:
@clvm_streamable#17715)@clvm_streamable#17715Additional changes after the initial commit b79e2ea may be made due to review comments