-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHIA-598] Create check for a virtual project structure #17810
Open
Quexington
wants to merge
50
commits into
main
Choose a base branch
from
quex.experiment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,047
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57eda2a
to
e589743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Added
Required label for PR that categorizes merge commit message as "Added" for changelog
coverage-diff
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this PR is to create a stepping stone into a piecemeal solution of sorting out the complicated interdependencies of the monorepo. The change is simple:
The annotations in this PR are not intended to be permanent or indicative of some firmer opinion. They are simply a set of opinions that can be changed arbitrarily at a later date. The annotation format can also be migrated relatively simply if we decide the existing format is not great. The idea is that these changes can be made by smaller groups with better focus over time rather than needing to have a big, likely highly controversial migration.
Ideally, one day there will be no dependency cycles ignored and we can draw a definitive dependency graph and at that point potentially start breaking bits out into their own repos, solidifying APIs, and publishing the constituent packages with independent stable versions.
As of 4/24/24 here's the existing virtual dependency graph: