Remove tx_records from dl_update_multiple RPC (breaking change)
#17846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
RPC
Quexington
requested review from
altendky and
geoffwalmsley
and removed request for
altendky
geoffwalmsley
approved these changes
Apr 11, 2024
emlowe
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RPC is not very used so instead of adding to the backwards compatibility special cases here: https://github.com/Chia-Network/chia-blockchain/blob/main/chia/rpc/util.py#L147 I would prefer to just delete this old value in favor of the newer one.
There's also some code deletion in this PR which is redundant after the addition of the new
@marshaldecorator.