Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to use no more than 61 cpus on windows #17958

Merged
merged 2 commits into from
May 8, 2024
Merged

Make sure to use no more than 61 cpus on windows #17958

merged 2 commits into from
May 8, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented May 2, 2024

Add back in code that limits CPUs to 61 on windows

@emlowe emlowe requested a review from a team as a code owner May 2, 2024 23:36
@emlowe emlowe added 1.6.0 Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog labels May 2, 2024
@arvidn
Copy link
Contributor

arvidn commented May 3, 2024

I think we only validate batches of 32 blocks at a time right now, so we probably can't utilize all 61 cores anyway

@altendky altendky mentioned this pull request May 3, 2024
Closed
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 8931944955

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 34 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.009%) to 90.677%
Files with Coverage Reduction New Missed Lines %
chia/harvester/harvester_api.py 1 73.02%
chia/full_node/full_node_api.py 1 80.92%
chia/wallet/wallet_node.py 1 88.68%
chia/server/node_discovery.py 4 79.79%
chia/full_node/full_node.py 5 84.81%
chia/_tests/core/util/test_lockfile.py 22 77.73%
Totals Coverage Status
Change from base Build 8931619722: -0.009%
Covered Lines: 98002
Relevant Lines: 108018
💛 - Coveralls

@cmmarslender cmmarslender merged commit 61e22fe into main May 8, 2024
357 checks passed
@cmmarslender cmmarslender deleted the EL.win-max-cpus branch May 8, 2024 04:02
altendky pushed a commit that referenced this pull request May 22, 2024
@emlowe @altendky
Make sure to use no more than 61 cpus on windows (#17958)
19884ed 
* Make sure to use no more than 61 cpus on windows

* Type fix

(cherry picked from commit 61e22fe)
@madMAx43v3r madMAx43v3r mentioned this pull request May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altendky altendky altendky approved these changes

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
1.6.0 Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emlowe @arvidn @altendky @cmmarslender