-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHIA-618 Explore limiting replace by fee to only one spend bundle #18006
base: main
Are you sure you want to change the base?
Conversation
f81fdf1
to
5c86982
Compare
let's wait for the architecture call to have a wider discussion about this. I think it makes sense as a short-term improvement. |
@@ -599,7 +599,7 @@ async def validate_spend_bundle( | |||
|
|||
if fail_reason is Err.MEMPOOL_CONFLICT: | |||
log.debug(f"Replace attempted. number of MempoolItems: {len(conflicts)}") | |||
if not can_replace(conflicts, removal_names, potential): | |||
if len(conflicts) > 1 or not can_replace(conflicts, removal_names, potential): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the point of this is to remove the super-set rule as well, right?
in can_replace()
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Idea suggested by @Rigidity.