Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-595: Soft fork 5 #18072

Merged
merged 2 commits into from
May 30, 2024
Merged

CHIA-595: Soft fork 5 #18072

merged 2 commits into from
May 30, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented May 23, 2024

Purpose:

Introduce the Soft-fork 5 logic and testing infrastructure. Activate the banning of infinity G1 points with the soft-fork.
The keccak and base64 will most likely also be added to the soft fork in a later PR.

Current Behavior:

There is no soft-fork 5

New Behavior:

There is a soft-fork 5 at height 5940000 on mainnet and 1340000 on testnet11.
When this soft fork activates, infinity G1 public keys are not allowed on AGG_SIG_* conditions.

@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label May 24, 2024
@arvidn arvidn marked this pull request as ready for review May 24, 2024 09:24
@arvidn arvidn requested a review from a team as a code owner May 24, 2024 09:24
@arvidn arvidn changed the title Soft fork 5 CHIA-595: Soft fork 5 May 24, 2024
Copy link

Pull Request Test Coverage Report for Build 9219593833

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 4 files are covered.
  • 25 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.002%) to 90.873%

Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 81.0%
chia/wallet/wallet_node.py 1 89.08%
chia/_tests/core/full_node/test_transactions.py 1 99.11%
chia/daemon/client.py 1 73.94%
chia/_tests/core/util/test_file_keyring_synchronization.py 1 97.1%
chia/_tests/core/test_farmer_harvester_rpc.py 2 98.03%
chia/server/node_discovery.py 3 79.61%
chia/_tests/core/util/test_lockfile.py 5 88.66%
chia/introducer/introducer_api.py 5 78.26%
chia/introducer/introducer.py 5 78.26%
Totals Coverage Status
Change from base Build 9211882961: -0.002%
Covered Lines: 99354
Relevant Lines: 109274

💛 - Coveralls

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label May 24, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 24, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@arvidn arvidn requested a review from Rigidity May 30, 2024 17:40
Copy link
Contributor

@Rigidity Rigidity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arvidn arvidn requested a review from wjblanke May 30, 2024 18:08
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label May 30, 2024
@cmmarslender cmmarslender merged commit a83b240 into main May 30, 2024
361 checks passed
@cmmarslender cmmarslender deleted the soft-fork-5 branch May 30, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants