Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIA-767 Simplify invariant_check_mempool #18176

Merged
merged 1 commit into from
Jun 20, 2024
Merged

CHIA-767 Simplify invariant_check_mempool #18176

merged 1 commit into from
Jun 20, 2024

Conversation

AmineKhaldi
Copy link
Contributor

No description provided.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Jun 13, 2024
@AmineKhaldi AmineKhaldi self-assigned this Jun 13, 2024
@AmineKhaldi AmineKhaldi reopened this Jun 18, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9566863452

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 53 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.03%) to 90.881%
Files with Coverage Reduction New Missed Lines %
chia/rpc/rpc_server.py 1 88.7%
chia/timelord/timelord_launcher.py 1 69.34%
chia/server/node_discovery.py 2 81.03%
chia/wallet/wallet_node.py 3 88.86%
chia/full_node/full_node.py 11 86.11%
chia/timelord/timelord.py 13 72.28%
chia/_tests/core/util/test_lockfile.py 22 77.73%
Totals Coverage Status
Change from base Build 9565949419: -0.03%
Covered Lines: 100178
Relevant Lines: 110170
💛 - Coveralls

@arvidn
Copy link
Contributor

arvidn commented Jun 20, 2024

@cmmarslender since the one failing test is now understood to be caused by signing secrets not being available on external repos, I think we could make an exception and land this PR anyway.

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Jun 20, 2024
@AmineKhaldi AmineKhaldi marked this pull request as ready for review June 20, 2024 12:39
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner June 20, 2024 12:39
@cmmarslender cmmarslender merged commit e0c36e8 into Chia-Network:main Jun 20, 2024
712 of 714 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees

@AmineKhaldi AmineKhaldi

Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AmineKhaldi @arvidn @cmmarslender