Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed lerna from build_scripts #18180

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

ChiaMineJP
Copy link
Contributor

@ChiaMineJP ChiaMineJP commented Jun 14, 2024

Use lerna in chia-blockchain-gui instead of the one installed inbuild_scripts/npm_{linux,macos,windows}/

@ChiaMineJP ChiaMineJP added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jun 14, 2024
@ChiaMineJP ChiaMineJP self-assigned this Jun 14, 2024
@ChiaMineJP ChiaMineJP requested a review from a team as a code owner June 14, 2024 13:02
Copy link

socket-security bot commented Jun 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/lerna@8.1.3, npm/nx@19.0.1

View full report↗︎

Copy link

coveralls-official bot commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9516592192

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.005%) to 90.859%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.5%
chia/daemon/keychain_proxy.py 1 72.57%
chia/farmer/farmer.py 1 72.23%
chia/wallet/wallet_node.py 1 88.94%
chia/timelord/timelord_launcher.py 1 69.34%
chia/daemon/server.py 1 83.22%
chia/introducer/introducer.py 1 78.26%
chia/full_node/full_node_api.py 2 81.66%
chia/daemon/client.py 2 73.33%
chia/server/ws_connection.py 2 88.69%
Totals Coverage Status
Change from base Build 9490807938: -0.005%
Covered Lines: 100015
Relevant Lines: 110015

💛 - Coveralls

Copy link

coveralls-official bot commented Jun 16, 2024

Pull Request Test Coverage Report for Build 9536484023

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.003%) to 90.861%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.5%
chia/daemon/client.py 1 73.94%
chia/daemon/server.py 1 83.22%
chia/introducer/introducer.py 1 78.26%
chia/full_node/full_node_api.py 2 81.73%
chia/server/node_discovery.py 2 78.9%
chia/server/ws_connection.py 2 88.69%
chia/rpc/rpc_server.py 3 88.04%
chia/full_node/full_node.py 7 85.85%
Totals Coverage Status
Change from base Build 9490807938: -0.003%
Covered Lines: 100017
Relevant Lines: 110015

💛 - Coveralls

Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reads ok, but presumably someone actually familiar with npm etc should give a review as well. thanks.

build_scripts/build_macos-2-installer.sh Outdated Show resolved Hide resolved
Copy link

coveralls-official bot commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9555854453

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 33 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.008%) to 90.856%

Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 72.57%
chia/farmer/farmer.py 1 72.23%
chia/timelord/timelord_launcher.py 1 69.34%
chia/daemon/server.py 1 83.22%
chia/introducer/introducer.py 1 78.26%
chia/full_node/full_node_api.py 2 81.66%
chia/full_node/weight_proof.py 2 90.51%
chia/farmer/farmer_api.py 2 94.4%
chia/daemon/client.py 2 73.33%
chia/server/ws_connection.py 2 88.69%
Totals Coverage Status
Change from base Build 9490807938: -0.008%
Covered Lines: 100008
Relevant Lines: 110009

💛 - Coveralls

@altendky altendky dismissed their stale review June 18, 2024 00:35

concerns were addressed

@ChiaMineJP ChiaMineJP requested a review from seeden June 18, 2024 11:27
@emlowe
Copy link
Contributor

emlowe commented Jun 18, 2024

Very nice , thanks Izumi - always nice to simplify and cleanup scripts

@cmmarslender cmmarslender merged commit 7034c04 into main Jun 18, 2024
363 checks passed
@cmmarslender cmmarslender deleted the cmj.removed-lerna-from-build-scripts branch June 18, 2024 19:23
altendky added a commit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants