Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor installer publish jobs #18220

Draft
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Jun 20, 2024

Purpose:

  • Make the publish jobs better aligned across platforms in preparation for switching to a reusable workflow to dedupe them
  • Clearly define file names one time and then reuse those single variables
  • Publish a single platform/arch/mode (cli vs. gui) per job to leverage matrixing across platforms

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog CI CI changes labels Jun 20, 2024
Copy link

coveralls-official bot commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9645631001

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 146 unchanged lines in 27 files lost coverage.
  • Overall coverage decreased (-0.03%) to 90.902%

Files with Coverage Reduction New Missed Lines %
chia/data_layer/data_store.py 1 94.37%
chia/data_layer/download_data.py 1 83.58%
chia/_tests/simulation/test_simulation.py 1 96.5%
chia/_tests/util/test_priority_mutex.py 1 99.66%
chia/_tests/util/test_action_scope.py 1 99.01%
chia/_tests/core/mempool/test_mempool_manager.py 1 99.89%
chia/timelord/timelord_launcher.py 1 69.34%
chia/types/mempool_item.py 1 98.31%
chia/_tests/util/full_sync.py 1 88.95%
chia/daemon/client.py 1 73.94%
Totals Coverage Status
Change from base Build 9614112249: -0.03%
Covered Lines: 100242
Relevant Lines: 110214

💛 - Coveralls

Copy link

coveralls-official bot commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9665155157

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 452 unchanged lines in 25 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.904%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.5%
chia/daemon/keychain_proxy.py 1 72.57%
chia/cmds/dao_funcs.py 1 99.65%
chia/farmer/farmer.py 1 72.23%
chia/plotters/madmax.py 1 50.6%
chia/daemon/client.py 1 73.33%
chia/daemon/server.py 1 83.22%
chia/cmds/dao.py 1 99.52%
chia/timelord/timelord.py 2 73.67%
chia/_tests/pools/test_pool_cmdline.py 2 60.0%
Totals Coverage Status
Change from base Build 9650300892: 0.02%
Covered Lines: 100750
Relevant Lines: 110783

💛 - Coveralls

Copy link

coveralls-official bot commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9669846331

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 441 unchanged lines in 23 files lost coverage.
  • Overall coverage increased (+0.05%) to 90.943%

Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 72.57%
chia/cmds/dao_funcs.py 1 99.65%
chia/farmer/farmer.py 1 72.23%
chia/wallet/wallet_node.py 1 88.86%
chia/server/node_discovery.py 1 81.21%
chia/daemon/client.py 1 73.33%
chia/cmds/dao.py 1 99.52%
chia/timelord/timelord.py 2 73.67%
chia/_tests/pools/test_pool_cmdline.py 2 60.0%
chia/data_layer/data_layer.py 2 85.32%
Totals Coverage Status
Change from base Build 9650300892: 0.05%
Covered Lines: 100793
Relevant Lines: 110783

💛 - Coveralls

@altendky altendky changed the title refactor installer build workflows refactor installer publish workflows Jun 26, 2024
@altendky altendky changed the title refactor installer publish workflows refactor installer publish jobs Jun 26, 2024
@altendky altendky marked this pull request as ready for review June 26, 2024 19:40
@altendky altendky requested a review from a team as a code owner June 26, 2024 19:40
Copy link

coveralls-official bot commented Jun 26, 2024

Pull Request Test Coverage Report for Build 9684148903

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 750 unchanged lines in 27 files lost coverage.
  • Overall coverage increased (+0.1%) to 90.985%

Files with Coverage Reduction New Missed Lines %
chia/_tests/wallet/rpc/test_wallet_rpc.py 1 99.68%
chia/_tests/wallet/dao_wallet/test_dao_wallets.py 1 99.95%
chia/wallet/wallet_node.py 1 88.79%
chia/cmds/chia.py 1 76.47%
chia/timelord/timelord_launcher.py 1 69.34%
chia/cmds/dao.py 1 99.54%
chia/rpc/util.py 2 98.89%
chia/_tests/pools/test_pool_rpc.py 2 99.08%
chia/wallet/util/clvm_streamable.py 2 98.1%
chia/_tests/pools/test_pool_cmdline.py 2 60.0%
Totals Coverage Status
Change from base Build 9650300892: 0.1%
Covered Lines: 101668
Relevant Lines: 111696

💛 - Coveralls

@altendky altendky marked this pull request as draft June 26, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog CI CI changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant