Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix argument conversion for Program::_run() #350

Merged
merged 1 commit into from
Dec 17, 2023
Merged

fix argument conversion for Program::_run() #350

merged 1 commit into from
Dec 17, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Dec 17, 2023

to match SerializedProgram._run().

This is a bit messy, see comment in Program.rs

@arvidn arvidn requested a review from Rigidity December 17, 2023 12:23
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 7238415742

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 86.143%
Totals Coverage Status
Change from base Build 7228349950: 0.07%
Covered Lines: 10879
Relevant Lines: 12629
💛 - Coveralls

@arvidn arvidn marked this pull request as ready for review December 17, 2023 12:37
@arvidn arvidn merged commit 7186de0 into main Dec 17, 2023
54 checks passed
@arvidn arvidn deleted the program-run branch December 17, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rigidity Rigidity Rigidity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvidn @Rigidity