Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy and test fixes, black formatting #456

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Mypy and test fixes, black formatting #456

merged 7 commits into from
Apr 5, 2024

Conversation

Rigidity
Copy link
Contributor

@Rigidity Rigidity commented Apr 5, 2024

This fixes mypy errors, type stubs, and formats all of the test files with black. Black formatting is checked in CI as well.

You can review one commit at a time, and mostly ignore the "Black formatting" commit, since no changes were made in it other than formatting and adding CI to enforce the formatting.

@Rigidity Rigidity changed the title Fix type stubs Mypy and test fixes Apr 5, 2024
Copy link

coveralls-official bot commented Apr 5, 2024

Pull Request Test Coverage Report for Build 8569782024

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.544%

Totals Coverage Status
Change from base Build 8558009590: 0.0%
Covered Lines: 11350
Relevant Lines: 13268

💛 - Coveralls

@Rigidity Rigidity changed the title Mypy and test fixes Mypy and test fixes, black formatting Apr 5, 2024
@Rigidity Rigidity requested a review from arvidn April 5, 2024 04:12
@Rigidity Rigidity marked this pull request as ready for review April 5, 2024 04:12
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it all looks good, except the type of the atom property should be Optional[bytes] as far as I can tell

wheel/chia_rs.pyi Outdated Show resolved Hide resolved
wheel/chia_rs.pyi Show resolved Hide resolved
arvidn
arvidn previously approved these changes Apr 5, 2024
@Rigidity Rigidity merged commit 6d366c0 into main Apr 5, 2024
64 checks passed
@Rigidity Rigidity deleted the python-fixes branch April 5, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants