-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
one matrix to rule them all (well, some anyways) #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
altendky
commented
Jun 21, 2022
•
edited
Loading
edited
- Restructures to a single workflow for all platforms including ARM
- Update to cibuildwheel 2.7.0
- Use cibuildwheel for all wheel builds
- Build each wheel in a separate cibuildwheel call to use GitHub Actions matrixing for all dimensions
- Use pyenv for Python instead of Brew, via https://github.com/Chia-Network/actions/tree/9db4629fff0376ae272144e87ae6816179bf5fc9/setup-python
- Enable top level GitHub Actions concurrency limits
- Use https://github.com/Chia-Network/actions/tree/9db4629fff0376ae272144e87ae6816179bf5fc9/clean-workspace
- Break into multiple matrices for building wheels vs. sdist vs checks vs. uploading to PyPI
- Build sdist on Linux with Python 3.9
cmmarslender
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
emlowe
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good for me
wjblanke
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aok
This was referenced Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.