Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLS operator signatures #287

Merged
merged 1 commit into from
May 16, 2023
Merged

BLS operator signatures #287

merged 1 commit into from
May 16, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented May 16, 2023 •
edited
Loading

This changes the signatures of bls_verify from signature (G1 . msg) (G1 . msg) ... to signature G1 msg G1 msg ....
and the signature of bls_pairing_identity from (G1 . G2) (G1 . G2) ... to G1 G2 G1 G2 ...

@coveralls-official
Copy link

coveralls-official bot commented May 16, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4996169587

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 91.791%
Totals Coverage Status
Change from base Build 4996143715: -0.01%
Covered Lines: 4126
Relevant Lines: 4495
💛 - Coveralls

@arvidn arvidn mentioned this pull request May 16, 2023
Merged
@arvidn
change signature of bls_verify and bls_pairing_identity to take its l…
737abc6 
…ist of pairs as flat varargs, rather than list of cons-pairs
@arvidn arvidn marked this pull request as ready for review May 16, 2023 20:12
richardkiss
richardkiss approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@richardkiss richardkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@arvidn arvidn merged commit c328f54 into main May 16, 2023
@arvidn arvidn deleted the bls-signatures branch May 16, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardkiss richardkiss richardkiss approved these changes

@cameroncooper cameroncooper cameroncooper approved these changes

@Quexington Quexington Awaiting requested review from Quexington

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arvidn @richardkiss @cameroncooper