Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependencies #435

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Bump dependencies #435

merged 3 commits into from
Jul 11, 2024

Conversation

Rigidity
Copy link
Contributor

@Rigidity Rigidity commented Jul 11, 2024 •
edited

Pyo3 uses Bound instead of references now.

@Rigidity Rigidity requested a review from arvidn July 11, 2024 13:33
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jul 11, 2024 •
edited

Pull Request Test Coverage Report for Build 9894834214

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 94.152%
Files with Coverage Reduction New Missed Lines %
wasm/src/run_program.rs 1 0.0%
wasm/src/lazy_node.rs 1 0.0%
Totals Coverage Status
Change from base Build 9894506010: -0.03%
Covered Lines: 5828
Relevant Lines: 6190
💛 - Coveralls

This was referenced Jul 11, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
jack60612
jack60612 previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@jack60612 jack60612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, not 100% sure about new bound though

@Rigidity Rigidity requested a review from jack60612 July 11, 2024 16:08
jack60612
jack60612 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@jack60612 jack60612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. reapproved

wjblanke
wjblanke approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@Rigidity Rigidity merged commit 90915aa into main Jul 11, 2024
29 checks passed
@Rigidity Rigidity deleted the bump-deps branch July 11, 2024 17:05
@jack60612 jack60612 mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

@jack60612 jack60612 jack60612 approved these changes

@arvidn arvidn Awaiting requested review from arvidn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rigidity @wjblanke @jack60612