20230326 better print #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a new 'Print' key to the step run output for it. Because it's an 'all' primitive, it can't be skipped if anything dynamic is in one of its arguments. The user can decide how to incorporate functions that use this signal, as in whether to print the value passing through or not. It can be matched at runtime without symbols and puts all consumers on the same footing. Add a test to test_clvm_step.py and a test of the command line tool.
…a new 'Print' key to the step run output for it. Because it's an 'all' primitive, it can't be skipped if anything dynamic is in one of its arguments. The user can decide how to incorporate functions that use this signal, as in whether to print the value passing through or not. It can be matched at runtime without symbols and puts all consumers on the same footing. Add a test to test_clvm_step.py and a test of the command line tool.
…a new 'Print' key to the step run output for it. Because it's an 'all' primitive, it can't be skipped if anything dynamic is in one of its arguments. The user can decide how to incorporate functions that use this signal, as in whether to print the value passing through or not. It can be matched at runtime without symbols and puts all consumers on the same footing. Add a test to test_clvm_step.py and a test of the command line tool.
…h --features in maturin command line
Improve printing speed
AmineKhaldi
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better printing. Use the simple method of matching (all ...) and add a new 'Print' key to the step run output for it. Because it's an 'all' primitive, it can't be skipped if anything dynamic is in one of its arguments. The user can decide how to incorporate functions that use this signal, as in whether to print the value passing through or not. It can be matched at runtime without symbols and puts all consumers on the same footing. Add a test to test_clvm_step.py and a test of the command line tool.