Skip to content

Commit

Permalink
Merge f13644b into 842f9e3
Browse files Browse the repository at this point in the history
  • Loading branch information
geneorama committed May 15, 2019
2 parents 842f9e3 + f13644b commit 8bca77e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Expand Up @@ -10,8 +10,8 @@ Description: Provides easier interaction with
format and manages throttling by 'Socrata'.
Users can upload data to 'Socrata' portals directly
from R.
Version: 1.7.7-1
Date: 2019-04-26
Version: 1.7.8-4
Date: 2019-05-14
Author: Hugh Devlin, Ph. D., Tom Schenk, Jr., Gene Leynes, Nick Lucius, John Malc, Mark Silverberg, and Peter Schmeideskamp
Maintainer: "Tom Schenk Jr." <developers@cityofchicago.org>
Depends:
Expand Down
10 changes: 5 additions & 5 deletions tests/testthat/test-all.R
Expand Up @@ -255,11 +255,11 @@ test_that("read Socrata JSON with missing fields (issue 19 - bind within page)",

test_that("read Socrata JSON with missing fields (issue 19 - binding pages together)", {
## Define and test issue 19
expect_error(df <- read.socrata(paste0("https://data.smgov.net/resource/ia9m-wspt.json?",
"$where=incident_date>'2010-12-15'%20AND%20incident_date<'2011-01-15'"))
, NA, info = "https://github.com/Chicago/RSocrata/issues/19")
expect_equal(7927, nrow(df), label="rows", info = "https://github.com/Chicago/RSocrata/issues/19")
expect_equal(18, ncol(df), label="columns", info = "https://github.com/Chicago/RSocrata/issues/19")
df <- read.socrata(paste0("https://data.smgov.net/resource/ia9m-wspt.json?",
"$where=incident_date>='2011-01-01'%20AND%20incident_date<'2011-01-15'"))
expect_error(df, NA, info = "https://github.com/Chicago/RSocrata/issues/19")
expect_equal(3719, nrow(df), label="rows", info = "https://github.com/Chicago/RSocrata/issues/19")
expect_equal(15, ncol(df), label="columns", info = "https://github.com/Chicago/RSocrata/issues/19")
})

test_that("Accept a URL with a $limit= clause and properly limit the results", {
Expand Down

0 comments on commit 8bca77e

Please sign in to comment.