Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons broken on README #134

Closed
tomschenkjr opened this issue Mar 15, 2017 · 2 comments
Closed

Icons broken on README #134

tomschenkjr opened this issue Mar 15, 2017 · 2 comments
Assignees
Milestone

Comments

@tomschenkjr
Copy link
Contributor

Just noticed this today, but I'm pretty sure this was just working. The Travis CI, AppVeyor and other little icons are broken.

The primary suspect is GitHub's recent change in their Markdown rendering engine.

@geneorama
Copy link
Member

Thanks for the heads up, this is an exciting development on markdown! (although it may cause some short term pain...)

@tomschenkjr tomschenkjr self-assigned this Mar 21, 2017
@tomschenkjr
Copy link
Contributor Author

Ok, figured this out. The new GitHub parser for Markdown does not like spaces in the URL

Below is an incorrect and correct example for a link to a Shields.io badge. In particular, the label=Linux build was causing it to not render appropriately.

Incorrect

![](https://img.shields.io/travis/Chicago/RSocrata/master.svg?style=flat-square&label=Linux build)

Correct

![](https://img.shields.io/travis/Chicago/RSocrata/master.svg?style=flat-square&label=Linux%20build)

tomschenkjr added a commit that referenced this issue Mar 21, 2017
@tomschenkjr tomschenkjr added this to the 1.7.2 milestone Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants