Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plenario Changes #251

Closed
wants to merge 5 commits into from
Closed

Plenario Changes #251

wants to merge 5 commits into from

Conversation

nfspeedypur
Copy link
Contributor

This contains all of the changes that were needed to create Chicago.opengrid.io. Some of the functionality has flags for turning it on/off, but other functionality has just been commented out.

We will need to discuss what other changes are needed on top of these updates.

@tomschenkjr
Copy link
Contributor

@nfspeedypur - can you sign the contributor license agreement? Just need to ensure that you're giving us permission to use the code.

@rladines - I've assigned the review of the PR to you. Can you kick-off a review by clicking "Add your review" link above? If everything looks good, then approve it. Otherwise, make notes on the PR.

We'll need to wait until the CLA is signed before accepting.

@rladines
Copy link
Collaborator

@tomschenkjr @nfspeedypur sorry, I have not had a chance to spend a lot of time reviewing the PR this week. Would it be cleaner if we create an issue branch (do we have an issue created for a common code base already?), and use this as the target for the pull request? I'm thinking that way, we have that branch to clean up as we try and make the public-facing OpenGrid code work with the core code as generically as possible.

Once we have a clean working issue branch, then we'll merge than into dev, do one more round of testing, maybe even pull in the changes in WG to do more validation. Finally merge into master, if all goes well.

@rladines
Copy link
Collaborator

@tomschenkjr @nfspeedypur I'm closing this pull request.

@nfspeedypur pls. re-issue the pull request against this new branch based on dev ms130_commoncore. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants