Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created linter workflow with ESLint #40

Merged
merged 20 commits into from
Mar 7, 2023
Merged

Created linter workflow with ESLint #40

merged 20 commits into from
Mar 7, 2023

Conversation

reembot
Copy link
Contributor

@reembot reembot commented Mar 3, 2023

Issue #19

@reembot reembot added the DevOps Concerns developer operations label Mar 3, 2023
.github/workflows/linter.yml Outdated Show resolved Hide resolved
@AbhinavReddy-Dev
Copy link
Contributor

We will need add to the .eslintrc file in the root folder of the repo, also we can add a .eslintrcignore or add ignorePatterns option in the .eslintrc file to ignore linting any specific files or directories. https://stackoverflow.com/questions/48087277/eslint-only-target-a-specific-directory-eslintrc-create-react-app

@reembot
Copy link
Contributor Author

reembot commented Mar 6, 2023

We will need add to the .eslintrc file in the root folder of the repo, also we can add a .eslintrcignore or add ignorePatterns option in the .eslintrc file to ignore linting any specific files or directories. https://stackoverflow.com/questions/48087277/eslint-only-target-a-specific-directory-eslintrc-create-react-app

@AbhinavReddy-Dev
There is a .eslintrc.jcs file added to the root directory- check the "Files changed" tab to view.

I'll look into the other suggestions, thank you!

.eslintrc.cjs Outdated Show resolved Hide resolved
.eslintrc.cjs Show resolved Hide resolved
@Jooms
Copy link
Contributor

Jooms commented Mar 7, 2023

Looks great and passes

@reembot reembot self-assigned this Mar 7, 2023
@AbhinavReddy-Dev AbhinavReddy-Dev self-requested a review March 7, 2023 04:36
@reembot reembot merged commit a380f60 into main Mar 7, 2023
@reembot reembot deleted the linter branch March 7, 2023 04:40
@Jooms Jooms mentioned this pull request Mar 7, 2023
4 tasks
briswells pushed a commit that referenced this pull request Mar 23, 2023
* added worklflow directory and eslint config file to root

* removed hyphens for run commands

* removed extra 'uses' command

* removed extra ts install cmd

* merged npm install cmds

* removed separate install cmd

* finally running with separated named steps

* testing new ignore options in run commands

* added separate name for setup-node use

* added npx command for final run line

* removed trigger for pushes to linter branch

* added error suppression to rules for temporary relief

* reverted to normal final run commandwith error suppression defined in .eslintrc file

* removed Setup node step

* fixed linter configuration for proper run

* added proper suppression of no-undef error to warning status. Linter operational, update issue #19

* cleaned up rule duplicates, issue #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps Concerns developer operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants