Add missing type error message (#5346)

ChilliCream · Sep 12, 2022 · 5c822d4 · 5c822d4
1 parent 79c8093
commit 5c822d4
Show file tree

Hide file tree

Showing 5 changed files with 370 additions and 318 deletions.
diff --git a/src/HotChocolate/Core/src/Types/Configuration/TypeInitializer.cs b/src/HotChocolate/Core/src/Types/Configuration/TypeInitializer.cs
@@ -458,10 +458,21 @@ private void FinalizeTypes()
 
                 IReadOnlyList<ITypeReference> needed =
                     TryNormalizeDependencies(type.Conditionals,
-                        out var normalized)
+                        out var normalized,
+                        out var notFound)
                         ? normalized.Except(processed).ToArray()
                         : type.Conditionals.Select(t => t.TypeReference).ToArray();
 
+                if (notFound != null)
+                {
+                    _errors.Add(SchemaErrorBuilder.New()
+                        .SetMessage(
+                            TypeInitializer_CannotFindType,
+                            string.Join(", ", notFound.Reverse()))
+                        .SetTypeSystemObject(type.Type)
+                        .Build());
+                }
+
                 _errors.Add(SchemaErrorBuilder.New()
                     .SetMessage(
                         TypeInitializer_CannotResolveDependency,
@@ -512,7 +523,9 @@ private void FinalizeTypes()
     {
         foreach (var type in _next)
         {
-            if (TryNormalizeDependencies(type.Conditionals, out var normalized) &&
+            if (TryNormalizeDependencies(type.Conditionals,
+                    out var normalized,
+                    out var _) &&
                 processed.IsSupersetOf(GetTypeRefsExceptSelfRefs(type, normalized)))
             {
                 yield return type;
@@ -553,7 +566,8 @@ private void FinalizeTypes()
 
     private bool TryNormalizeDependencies(
         List<TypeDependency> dependencies,
-        [NotNullWhen(true)] out IReadOnlyList<ITypeReference>? normalized)
+        [NotNullWhen(true)] out IReadOnlyList<ITypeReference>? normalized,
+        [NotNullWhen(false)] out IReadOnlyList<ITypeReference>? notFound)
     {
         var n = new List<ITypeReference>();
 
@@ -564,6 +578,8 @@ private void FinalizeTypes()
                 out var nr))
             {
                 normalized = null;
+                n.Add(dependency.TypeReference);
+                notFound = n;
                 return false;
             }
 
@@ -574,6 +590,7 @@ private void FinalizeTypes()
         }
 
         normalized = n;
+        notFound = null;
         return true;
     }