Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type error message #5346

Merged

Conversation

vmary2014
Copy link
Contributor

@vmary2014 vmary2014 commented Aug 26, 2022

Add a more concise error message when stitching errors occur

  • Altered TryNormalizeDependencies to provide a list of notFound items of type IReadOnlyList<ITypeReference>
  • Added an Unable to find type(s) {0} resource string

In the example provided in the original issue #5345 the error message added should be:

1. Unable to find type(s) None: [AuditLogEntitySortInput123!] (HotChocolate.Types.ObjectType)

And the second - original message - is kept and showing too.

Hope this is useful 👍

Closes #5345

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2022

CLA assistant check
All committers have signed the CLA.

@michaelstaib
Copy link
Member

@vmary2014 thanks for contributing...

Could you create a test that snapshots the error message.

@vmary2014
Copy link
Contributor Author

@vmary2014 thanks for contributing...

Could you create a test that snapshots the error message.

Hi @michaelstaib done. On my branch, aligned with the latest of version 12 I also added an integration test for the HotCholocate.Stitching project but it looks like this project is missing from the latest main. Once this is back I can add it later.

@michaelstaib michaelstaib merged commit 5c822d4 into ChilliCream:main Sep 12, 2022
@vmary2014
Copy link
Contributor Author

Thanks @michaelstaib for merging this. Do you know if it will make it to v12 too? Happy to raise a PR against your main-version-12 branch if you wish.

@michaelstaib
Copy link
Member

If you create a PR for the v12 branch I will merge it

@vmary2014
Copy link
Contributor Author

If you create a PR for the v12 branch I will merge it

Done here #5391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More concise error message when stitching errors occur
3 participants