Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name of LocalCurrency scalar is incorrect #5369

Closed
1 task done
benmccallum opened this issue Sep 5, 2022 · 2 comments · Fixed by #5368
Closed
1 task done

Name of LocalCurrency scalar is incorrect #5369

benmccallum opened this issue Sep 5, 2022 · 2 comments · Fixed by #5368
Labels
🐛 bug Something isn't working

Comments

@benmccallum
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Is LocalCurency and should be LocalCurrency. Docs refers to it correctly.

Current workaround:

.AddType(x => new LocalCurrencyType("LocalCurrency"))`

Steps to reproduce

  1. Use .AddType<LocalCurrencyType>(), see it in schema output as wrong.

Relevant log output

No response

Additional Context?

No response

Product

Hot Chocolate

Version

12.13.0
@benmccallum benmccallum added the 🐛 bug Something isn't working label Sep 5, 2022
@benmccallum benmccallum mentioned this issue Sep 5, 2022
Merged
@benmccallum
Copy link
Collaborator Author

Would it be considered a bug @michaelstaib that the workaround to add it with a better name ends up dropping off the type's description? e.g.

"The LocalCurrency scalar type is a currency string."
scalar LocalCurency

scalar LocalCurrency # missing desc

@michaelstaib
Copy link
Member

That is deliberate ... since when creating a new name you also specify kind of change sematics ... so keeping the description seems wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix name of LocalCurrency scalar type ChilliCream/graphql-platform
2 participants
@benmccallum @michaelstaib