Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of LocalCurrency scalar type #5368

Merged
merged 4 commits into from Sep 5, 2022
Merged

Conversation

benmccallum
Copy link
Collaborator

@benmccallum benmccallum commented Sep 5, 2022

Fixes #5369

This is kind of a breaking change, so I've milestoned it as v13, but feel free to retarget it wherever.

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2022

CLA assistant check
All committers have signed the CLA.

@benmccallum benmccallum added this to the HC-13.0.0 milestone Sep 5, 2022
@benmccallum benmccallum marked this pull request as ready for review September 5, 2022 02:04
@PascalSenn
Copy link
Member

@benmccallum cool thanks for the pr! :)
Regarding your comment in #5369:
Do you want to fix this behaviour?
https://github.com/ChilliCream/hotchocolate/blob/b8e3bd10f9c6a8247c602f8c52f0e14dadc3e361/src/HotChocolate/Core/src/Types.Scalars/LocalCurrencyType.cs#L38

Description = description ?? ScalarResources.LocalCurrencyType_Description;

@michaelstaib
Copy link
Member

@PascalSenn we drop the description deliberately. When you change the name of a scalar you often do so to change semantics.

Think about the string scalar where you now give it a meaning like EmployeeName .... now this scalar does no longer have the semantical meaning it had before and needs a new description.

@michaelstaib michaelstaib merged commit 5f0e65f into main Sep 5, 2022
@michaelstaib michaelstaib deleted the benmc/fix-scalar-name branch September 5, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name of LocalCurrency scalar is incorrect
4 participants