Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependencies from Strawberry Shake when provided by framework #6870

Closed
thompson-tomo opened this issue Feb 9, 2024 · 3 comments · Fixed by #6934
Closed

Remove dependencies from Strawberry Shake when provided by framework #6870

thompson-tomo opened this issue Feb 9, 2024 · 3 comments · Fixed by #6934
Labels
🎉 enhancement New feature or request

Comments

@thompson-tomo
Copy link
Contributor

Product

Strawberry Shake

Is your feature request related to a problem?

I want to reduce the package size & amount of dependencies to reduce surface area for CVE'S.

The solution you'd like

I would like that any dependency that can be provided by the framework ie System.Text.Json the framework is leveraged to reduce dependencies.
@thompson-tomo thompson-tomo added the 🎉 enhancement New feature or request label Feb 9, 2024
@thompson-tomo
Copy link
Contributor Author

Happy to submit this as a PR

@michaelstaib
Copy link
Member

closing this issue as this is an ongoing effort.

@thompson-tomo
Copy link
Contributor Author

@michaelstaib for the packages I identified as being able to be optimised would you accept PR?

@thompson-tomo thompson-tomo mentioned this issue Feb 9, 2024
Closed
thompson-tomo added a commit to thompson-tomo/graphql-platform that referenced this issue Feb 22, 2024
@thompson-tomo
ChilliCream#6870 Remove packages provided as dependency when part of …
d0dda08 
…framework
@thompson-tomo thompson-tomo mentioned this issue Feb 22, 2024
Merged
thompson-tomo added a commit to thompson-tomo/graphql-platform that referenced this issue Feb 22, 2024
@thompson-tomo
ChilliCream#6870 Remove packages provided as dependency when part of …
a602e59 
…framework
michaelstaib added a commit to thompson-tomo/graphql-platform that referenced this issue Feb 23, 2024
@michaelstaib
Merge branch 'main' into chore/ChilliCream#6870-StrawberryShakePackag…
c0787f2 
…eClean
michaelstaib pushed a commit that referenced this issue Feb 23, 2024
@thompson-tomo
#6870 Remove packages provided as dependency when part of framework (#…
6785dd3 
…6934)
@PascalSenn PascalSenn mentioned this issue May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎉 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#6870 Remove packages provided as dependency when part of framework thompson-tomo/graphql-platform
2 participants
@michaelstaib @thompson-tomo