Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6870 Remove packages provided as dependency when part of framework #6934

Conversation

thompson-tomo
Copy link
Contributor

Improve package handling with goal of reduction in dependencies

  • Removed polyfill packages for dotnet 6, 7 & 8
  • Downgraded ASPNET core 2.2 packages to 2.1 as they are being maintained and not 2.2

Closes #6870

@thompson-tomo thompson-tomo force-pushed the chore/#6870-StrawberryShakePackageClean branch from d0dda08 to a602e59 Compare February 22, 2024 21:25
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.21%. Comparing base (09eb3c0) to head (a602e59).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6934      +/-   ##
==========================================
+ Coverage   73.10%   73.21%   +0.11%     
==========================================
  Files        2572     2586      +14     
  Lines      127803   128439     +636     
==========================================
+ Hits        93424    94042     +618     
- Misses      34379    34397      +18     
Flag Coverage Δ
unittests 73.21% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib
Copy link
Member

Thanks again for your help!

@michaelstaib michaelstaib merged commit 6785dd3 into ChilliCream:main Feb 23, 2024
5 of 6 checks passed
@thompson-tomo thompson-tomo deleted the chore/#6870-StrawberryShakePackageClean branch February 23, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependencies from Strawberry Shake when provided by framework
2 participants