Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect cache control maxAge documentations #7056

Merged
merged 3 commits into from Apr 14, 2024

Conversation

kiangkuang
Copy link
Contributor

Fixes incorrect caching XML documentations to align with header cache-control max-age usage and code behaviour of using seconds instead of milliseconds.

Closes #7053

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.11%. Comparing base (ed99eb6) to head (2efabec).
Report is 1 commits behind head on main.

❗ Current head 2efabec differs from pull request most recent head 76eb914. Consider uploading reports for the commit 76eb914 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7056      +/-   ##
==========================================
+ Coverage   72.02%   72.11%   +0.09%     
==========================================
  Files        2607     2621      +14     
  Lines      130140   130776     +636     
==========================================
+ Hits        93728    94312     +584     
- Misses      36412    36464      +52     
Flag Coverage Δ
unittests 72.11% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tobias-tengler tobias-tengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@tobias-tengler
Copy link
Collaborator

Can you maybe update ICacheControlOptions.DefaultMaxAge as well?

@kiangkuang
Copy link
Contributor Author

I've updated ICacheControlOptions.DefaultMaxAge, let me know if there's anywhere else I have missed.

@michaelstaib michaelstaib merged commit b9ba23f into ChilliCream:main Apr 14, 2024
5 of 6 checks passed
@kiangkuang kiangkuang deleted the fix-caching-docs branch April 16, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HotChocolate.Caching outputs max-age header in milliseconds instead of seconds
4 participants