Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect cache control maxAge documentations #7056

Merged
merged 3 commits into from
Apr 14, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/HotChocolate/Caching/src/Caching/CacheControlAttribute.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public CacheControlAttribute()
}

/// <param name="maxAge">
/// The maximum time, in Milliseconds, the resource can be cached.
/// The maximum time, in seconds, the resource can be cached.
/// </param>
public CacheControlAttribute(int maxAge)
{
Expand Down Expand Up @@ -54,7 +54,7 @@ public CacheControlAttribute(int maxAge)
}

/// <summary>
/// The maximum time, in Milliseconds, this resource can be cached.
/// The maximum time, in seconds, this resource can be cached.
/// </summary>
public int MaxAge { get => _maxAge ?? 0; set => _maxAge = value; }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public static class CacheControlInterfaceTypeDescriptorExtensions
/// The <see cref="IInterfaceTypeDescriptor"/>.
/// </param>
/// <param name="maxAge">
/// The maximum time, in Milliseconds, fields of this
/// The maximum time, in seconds, fields of this
/// type should be cached.
/// </param>
/// <param name="scope">
Expand All @@ -37,7 +37,7 @@ public static class CacheControlInterfaceTypeDescriptorExtensions
/// The <see cref="IInterfaceTypeDescriptor{T}"/>.
/// </param>
/// <param name="maxAge">
/// The maximum time, in Milliseconds, fields of this
/// The maximum time, in seconds, fields of this
/// type should be cached.
/// </param>
/// <param name="scope">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public static class CacheControlObjectFieldDescriptorExtensions
/// The <see cref="IObjectFieldDescriptor"/>.
/// </param>
/// <param name="maxAge">
/// The maximum time, in Milliseconds, fields of this
/// The maximum time, in seconds, fields of this
/// type should be cached.
/// </param>
/// <param name="scope">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public static class CacheControlObjectTypeDescriptorExtensions
/// The <see cref="IObjectTypeDescriptor"/>.
/// </param>
/// <param name="maxAge">
/// The maximum time, in Milliseconds, fields of this
/// The maximum time, in seconds, fields of this
/// type should be cached.
/// </param>
/// <param name="scope">
Expand All @@ -38,7 +38,7 @@ public static class CacheControlObjectTypeDescriptorExtensions
/// The <see cref="IObjectTypeDescriptor{T}"/>.
/// </param>
/// <param name="maxAge">
/// The maximum time, in Milliseconds, fields of this
/// The maximum time, in seconds, fields of this
/// type should be cached.
/// </param>
/// <param name="scope">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public static class CacheControlUnionTypeDescriptorExtensions
/// The <see cref="IUnionTypeDescriptor"/>.
/// </param>
/// <param name="maxAge">
/// The maximum time, in Milliseconds, fields of this
/// The maximum time, in seconds, fields of this
/// type should be cached.
/// </param>
/// <param name="scope">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public interface ICacheConstraints
{
/// <summary>
/// The maximum time the query result shall be cached,
/// in Milliseconds.
/// in seconds.
/// </summary>
int MaxAge { get; }

Expand Down