Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Android wechat browser playsinline handle #69

Merged
merged 1 commit into from
Jan 9, 2018
Merged

[fix] Android wechat browser playsinline handle #69

merged 1 commit into from
Jan 9, 2018

Conversation

zhaofinger
Copy link
Contributor

在安卓微信里给video加上x5-playsinline属性可以让视频达到内嵌播放的效果。

@toxic-johann toxic-johann self-assigned this Jan 9, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 58c5b64 on zhaofinger:master into 6e0455d on Chimeejs:master.

@toxic-johann
Copy link
Member

closed #68

@toxic-johann toxic-johann merged commit a131a12 into Chimeejs:master Jan 9, 2018
@toxic-johann
Copy link
Member

谢谢~ @zhaofinger

@yandeqiang
Copy link
Contributor

@toxic-johann 安卓微信依旧全屏啊。

<video src="http://yunxianchang.live.ujne7.com/vod-system-bj/103_371ab0c0fda-143d-4755-8727-d3cd12dce02d.mp4" playsinline webkit-playsinline  x5-playsinline x5-video-player-type="h5" preload="metadata" controls></video>

这个 x5-playsinline x5-video-player-type="h5" 这两个属性感觉设置效果一致。 没有在文档里发现其关系与区别。

@toxic-johann
Copy link
Member

好的

@zhaofinger
Copy link
Contributor Author

我在安卓下测试单独使用x5-playsinline不使用x5-video-player-type同层属性,是可行的 @yandeqiang @toxic-johann

@zhaofinger
Copy link
Contributor Author

@yandeqiang @toxic-johann

我测试了下,在安卓中x5-video-player-typex5-playsinline同时使用,微信还是会强制全屏。
单独使用x5-playsinline则没有问题,可在微信中打开下面链接测试:https://zhaofinger.github.io/wechat-android-video/index.html

个人认为在chimee初始化的时候,设置了playsinline属性的的时候不应该同时设置x5-video-player-type,这个两个一个是内嵌播放一个是同层播放,x5-video-player-type应该搞一个单独的属性交由开发者设置 :)

@toxic-johann
Copy link
Member

好的。谢谢反馈~

toxic-johann added a commit that referenced this pull request May 31, 2019
[fix] Android wechat browser playsinline handle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants