Handle consumer key & secret per anaconda instance, not globally #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree this looks a lot neater, but it would break backwards compatibility. So this will probably be on hold until we decide to bump the major API version. |
|
No problem, the code is still here thus you're free to merge whenever you want it (and if you want it!). In the meantime, if someone wants to use the thread safe version it can just use my fork. |
muesli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the
oauthClientvariable within theTwitterAPIstructure and I changed every method that used theoauthClientvariable to use the new one, within the structure.In this way, we can spawn multiple thread-safe applications.
In short: fix #101