Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RemoveUserFromList / RemoveMultipleUsersFromList #247

Merged
merged 3 commits into from
Oct 7, 2018

Conversation

hem6
Copy link
Contributor

@hem6 hem6 commented Apr 6, 2018

Add following endpoints

  • /lists/members/destroy.json
  • /lists/members/destroy_all.json

lists.go Outdated
v.Set("list_id", strconv.FormatInt(listID, 10))
v.Set("screen_name", screenName)

var addUserToListResponse AddUserToListResponse
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually the correct response?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review. It's my mistake.:disappointed_relieved:
/lists/members/destroy.json returns the list.
Fixed the return type of RemoveUserFromList.

@muesli
Copy link
Collaborator

muesli commented Apr 10, 2018

Thanks, LGTM at first glance. A test case for it would be nice though.

@hem6
Copy link
Contributor Author

hem6 commented Apr 25, 2018

Thank you. I Added some test cases.

@amitizle
Copy link

amitizle commented Oct 3, 2018

Any update on this PR? looking forward using this endpoint 🙂

@ChimeraCoder ChimeraCoder merged commit 06c5e89 into ChimeraCoder:master Oct 7, 2018
iwataka added a commit to iwataka/anaconda that referenced this pull request May 5, 2022
* 'master' of https://github.com/ChimeraCoder/anaconda:
  add PostAccountUpdateProfile (ChimeraCoder#259)
  Add RemoveUserFromList / RemoveMultipleUsersFromList (ChimeraCoder#247)
  Update README for streaming API. (ChimeraCoder#241)
  Add Category struct and change GetUsersSuggestions to use it (ChimeraCoder#228)
  Use exclude instead of include directive for Travis (ChimeraCoder#235)
  Implement GetListMembers (ChimeraCoder#240)
  Cleaned up README indentations and captions (ChimeraCoder#237)
  Implement IndicateTyping endpoint (ChimeraCoder#236)
  Enforce a default HTTP client timeout (ChimeraCoder#226)
  Store OAuth credentials per TwitterApi instance (ChimeraCoder#222)
  Disable Go 1.6 tests on OS X in Travis (ChimeraCoder#232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants