-
Notifications
You must be signed in to change notification settings - Fork 17
Make the operating system version show in Steam #10
Conversation
set_hd_mode.sh was also moved here
@@ -0,0 +1,11 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But wouldn't the steam client call the original dpkg-query
and not this script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this I added a path export to the steamos-session script which put our bin directory first. This ensures that steam always execute our script. I added some safeguards into it in case Steam wants to use dpkg-query for anything else than getting the steamos-updatelevel version, then it will redirect to the original dpkg-query if it exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, nice approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some further testing, I concluded that the while loop in this script was causing some issues when a different command was used. I've pushed a fix for it into this pull request. See this commit
# Add our bin directory with the set_hd_mode and dpkg-query replacement scripts | ||
export PATH=/usr/share/steamos-compositor-plus/bin:${PATH} | ||
|
||
set_hd_mode.sh >> $HOME/set_hd_mode.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does moving set_hd_mode.sh
break the debian packaging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Debian packaging is currently broken, but it doesn't have issues with the scripts. It currently can't put the binaries it builds in the correct place, but that was already the case before these changes. I'll look into that some other time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I thought you had said you had managed to build it, but if it is already broken, no matter. Maybe we should just remove the debian directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep it for now. It isn't that hard to fix. The rules file will need to be changed to put the files in the correct directory after compiling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the debian package in pull request #11
The while loop caused some errors. This is a better solution.
I created a script which pretends to be dpkg-query in a bin directory specific to this package. I also moved the set_hd_mode.sh script there, since directories have no place in /usr/bin.
To deploy this, I also made some changes to the PKGBUILD for steamos-compositor-plus. If you were to tag this release with version 1.3.0, then this patch should be all you need:
Note that lsb-release is now a dependency.