Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previous button in playlist watch page #3485

Closed
King-Noctis opened this issue Dec 19, 2020 · 3 comments · Fixed by #3982
Closed

Previous button in playlist watch page #3485

King-Noctis opened this issue Dec 19, 2020 · 3 comments · Fixed by #3982
Assignees
@Poslovitch
Labels
Component: Player ⏯️ Component: Playlist Type: Feature Request ✨

Comments

@King-Noctis
Copy link

King-Noctis commented Dec 19, 2020 •
edited
Loading

Can you add a Previous button when playing video in playlists?
Thanks.

Screenshot 2020-12-18 180032
@Chocobozzz Chocobozzz changed the title Previous button? Previous button in playlist watch page Dec 22, 2020
@Poslovitch
Copy link
Contributor

I'm working on this.
I've got a working solution, but there's code duplication I would like to avoid.

@Chocobozzz
Copy link
Owner

@Poslovitch Our next button already supports "previous", so adding previousVideo below https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/app/%2Bvideos/%2Bvideo-watch/video-watch.component.ts#L801 should work

@Poslovitch
Copy link
Contributor

Sure, that's what I figured out. 😉

I have not found a way to get rid of code duplication yet. I'll open the PR as a draft, so that you can review it.

Poslovitch added a commit to Poslovitch/PeerTube that referenced this issue Apr 18, 2021
@Poslovitch
Added a "previous" button on player when watching playlist
5924953 
Implements Chocobozzz#3485
@Poslovitch Poslovitch mentioned this issue Apr 18, 2021
Merged
5 tasks
Chocobozzz pushed a commit that referenced this issue Apr 26, 2021
@Poslovitch @Chocobozzz
Added a "previous" button on player when watching playlist
33d21a9 
Implements #3485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Poslovitch Poslovitch

Labels
Component: Player ⏯️ Component: Playlist Type: Feature Request ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added a "previous" button on player when watching playlist Poslovitch/PeerTube
4 participants
@Chocobozzz @rigelk @Poslovitch @King-Noctis