Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a "previous" button on player when watching playlist #3982

Merged
merged 4 commits into from
Apr 26, 2021
Merged

Added a "previous" button on player when watching playlist #3982

merged 4 commits into from
Apr 26, 2021

Conversation

Poslovitch
Copy link
Contributor

@Poslovitch Poslovitch commented Apr 18, 2021 •
edited
Loading

Description

I have added a "previous" button on the player, as requested in #3485.

There are currently a few issues though:

  • It duplicates code from findNextPlaylistVideo() and navigateToNextPlaylistVideo()
  • Light tests showed this button was showing even when the user was not watching a playlist

Related issues

Resolves #3485

Has this been tested?

  • 馃憤 yes, I added tests to the test suite
  • 馃憤 yes, light tests as follows are enough
  • 馃挱 no, because this PR is a draft and still needs work
  • 馃檯 no, because they aren't needed
  • 馃檵 no, because I need help

Screenshots

image

@Poslovitch
Copy link
Contributor Author

Okay, now, what about the code duplication?

@Chocobozzz
Copy link
Owner

I refactored in c32a3f7

Thanks for the PR @Poslovitch

@Chocobozzz Chocobozzz marked this pull request as ready for review April 26, 2021 08:53
@Chocobozzz Chocobozzz merged commit fd78d2e into Chocobozzz:develop Apr 26, 2021
@Poslovitch Poslovitch deleted the feature/3485-previous-button-playlist branch April 26, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chocobozzz Chocobozzz Chocobozzz requested changes

Assignees
No one assigned
Labels
Component: Player 鈴笍 Component: Playlist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Previous button in playlist watch page
3 participants
@Poslovitch @Chocobozzz @rigelk