Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better label for views trending sort #4421

Closed
UnlimitedCookies opened this issue Sep 19, 2021 · 8 comments
Closed

Better label for views trending sort #4421

UnlimitedCookies opened this issue Sep 19, 2021 · 8 comments
Labels
Type: Feature Request ✨ UI non-trivial UI changes, that might need discussion

Comments

@UnlimitedCookies
Copy link

Describe the current behavior
Sorting by views does roughly sort by views, but not exactly.

Steps to reproduce:

https://peertube.debian.social/videos/local?sort=-trending&c=true&s=2
Shows 39 > 6 > 83 > 4

Describe the expected behavior
It should accurately sort by views.

  • PeerTube instance:

    • version: 3.4.0
    • NodeJS version: v12.22.6
    • Ffmpeg version: 4.2.4-1ubuntu0.1
  • Browser name, version and platforms on which you could reproduce the bug: Firefox and chromium

@Chocobozzz
Copy link
Owner

We still use the old trending algorithm, so the label should be more like "Views in last x days".

@Chocobozzz Chocobozzz added Type: Feature Request ✨ UI non-trivial UI changes, that might need discussion labels Oct 7, 2021
@Chocobozzz Chocobozzz changed the title Sorting by views is broken Better label for views trending sort Oct 7, 2021
Poslovitch added a commit to Poslovitch/PeerTube that referenced this issue Oct 23, 2021
@UnlimitedCookies
Copy link
Author

UnlimitedCookies commented Oct 26, 2021

@Chocobozzz Now what would be the way to sort by absolute number of views? Like most users expected this filter to behave according to the label that was used previously.

@UnlimitedCookies
Copy link
Author

@Chocobozzz Now what would be the way to sort by absolute number of views? Like most users expected this filter to behave according to the label that was used previously.

@Chocobozzz gentle and friendly ping :)

@Chocobozzz
Copy link
Owner

Now what would be the way to sort by absolute number of views? Like most users expected this filter to behave according to the label that was used previously.

You can use -views query sort param.

@UnlimitedCookies
Copy link
Author

Now what would be the way to sort by absolute number of views? Like most users expected this filter to behave according to the label that was used previously.

You can use -views query sort param.

?sort=-views seems to work, but why is this option not selectable in the drop-down?

@Chocobozzz
Copy link
Owner

We prefer to not put all available sort options in the dropdown to not confuse users.

@UnlimitedCookies
Copy link
Author

Personally, I would consider this a highly essential sort option, and I do not fully apprehend how this would confuse users. To the contrary, I find the filters "best", "hot" and "recent views" way more confusing as they don't communicate how videos are ranked, like a filter by absolute amount of views would.

@Chocobozzz
Copy link
Owner

I think you're right. We changed the sort select to implicitly use the Best algorithm when Hot is used (so we can remove "Best") and added the Global Views sort option in db19581 and 2b0d17c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request ✨ UI non-trivial UI changes, that might need discussion
Projects
None yet
Development

No branches or pull requests

2 participants