Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add way to set root password by environnement. #1814
Add a condition test to pass by environement a predetermined
Related work in documentation: https://framagit.org/framasoft/peertube/documentation/merge_requests/16
Maybe you could name your env var differently to make its use more obvious, like
 yeah, I know, it’s dumb because that password is in config file but still, it’s better to have obvious env var.
rigelk left a comment
That's the right place to go
much like what @ldidry said, I would rename the environment variable to something even more explicity.
@ALL: Thanks for your review! ☺
@ldidry I will make a change,
@rigelk : Thanks for the pointers to the documentation.
Is it a good idea to let run password validation on this?
Note: The validation is about pasword length https://github.com/Chocobozzz/PeerTube/blob/develop/server/helpers/custom-validators/users.ts#L10