-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add way to set root password by environnement. #1814
Conversation
Maybe you could name your env var differently to make its use more obvious, like [1] yeah, I know, it’s dumb because that password is in config file but still, it’s better to have obvious env var. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the right place to go 👍
much like what @ldidry said, I would rename the environment variable to something even more explicity. PT_INITIAL_ROOT_PASSWORD
seems fitting, because:
- we make explicit the scope (PT and not Postgres)
- we make explicit this only applies at the initialization
- we make explicit the user name
@ALL: Thanks for your review! ☺ @ldidry I will make a change, @rigelk : Thanks for the pointers to the documentation. Is it a good idea to let run password validation on this? Note: The validation is about pasword length https://github.com/Chocobozzz/PeerTube/blob/develop/server/helpers/custom-validators/users.ts#L10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a typo, LGTM.
update:
|
Add a condition test to pass by environment a predetermined root password for setting up.
Thanks @darnuria |
Add a condition test to pass by environement a predetermined
root password for setting up.
Related work in documentation: https://framagit.org/framasoft/peertube/documentation/merge_requests/16