Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pause video upon modal open #3909

Merged

Conversation

kontrollanten
Copy link
Contributor

Description

Removes the pausing of video upon modal open.

Related issues

Closes #3816

Has this been tested?

  • 👍 yes, light tests as follows are enough
  1. Start a video.
  2. Open share modal.
  3. Open download modal.
  4. Open some other modal from the action menu.

@Chocobozzz
Copy link
Owner

Hello,

You remove a behaviour added on purpose because the community asked for this feature (but I can't find the issue :/). So I'm not sure what we should do.

@kontrollanten
Copy link
Contributor Author

I couldn't find the issue either. An option could be to make it configurable, but I can't really see any big benefit with auto pausing upon modal open. It may be in some particular cases convenient to have the auto pause, but to me it seems really narrow. I think users expect the video to be playing in as many cases as possible, i.e. in iOS and Android most videos continue to play even when the user closes the browser.

@rigelk rigelk added Component: Player ⏯️ UI non-trivial UI changes, that might need discussion labels Apr 4, 2021
@Chocobozzz Chocobozzz merged commit ca87329 into Chocobozzz:develop Apr 8, 2021
@kontrollanten kontrollanten deleted the fix-3816-dont-pause-modal branch April 8, 2021 12:05
kontrollanten added a commit to kontrollanten/PeerTube that referenced this pull request Apr 9, 2021
* client: dont pause video upon modal open

closes Chocobozzz#3816

* client(video/watch): remove obsolete code

* gitignore: add vscode and vim swp files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Player ⏯️ UI non-trivial UI changes, that might need discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't pause video when modal is opened
3 participants